NAG compiler fix: skip implicit RPATH detection #15902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
approved these changes
Apr 7, 2020
…licit entry for loaded modules
alalazo
approved these changes
Apr 9, 2020
| @@ -250,13 +250,13 @@ def enable_new_dtags(self): | |||
| PrgEnv_compiler = None | |||
|
|
|||
| def __init__(self, cspec, operating_system, target, | |||
| paths, modules=[], alias=None, environment=None, | |||
| paths, modules=None, alias=None, environment=None, | |||
|
There had already been a fix for this problem: #14782. Should I close my PR then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15776
Skip collection of compiler link paths if compiler does not define a verbose flag. This includes NAG.
verbose_flag()is not implemented for the NAG compiler in Spack. It is possible that-Vis the appropriate choice for this. Since link-path detection logic involves compiling a C file, I'm not sure if it should be run at all if the available exe is meant for compiling Fortran.