Move compiler detection logic to packages #17525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalazo
force-pushed
the
features/move_compiler_detection_logic
branch
3 times, most recently
from
4546831
to
39fe3f7
Compare
8 tasks
alalazo
force-pushed
the
features/move_compiler_detection_logic
branch
from
39fe3f7
to
f9697a8
Compare
alalazo
force-pushed
the
features/move_compiler_detection_logic
branch
2 times, most recently
from
c1eb804
to
7c639e3
Compare
alalazo
force-pushed
the
features/move_compiler_detection_logic
branch
from
7c639e3
to
400e143
Compare
3 tasks
Moved data for compiler version detection in YAML file The test is unique and parametrized on different compilers.
Each package might define a YAML file in the same directory where the package.py resides. The file should be called "detection_test.yaml" and contain specifications to setup different detection scenarios. Currently only specs are checked, but we can extend the test to do a finer check on extra attributes.
The code in spack.cmd.external related to package detection has been moved to the spack.detection package. Added docstrings to functions.
The ExternalPackageEntry class was used to carry information on detected specs. Now this information is attached to the spec directly, so only specs are manipulated during the detection process.
alalazo
force-pushed
the
features/move_compiler_detection_logic
branch
from
400e143
to
f7ac7d0
Compare
|
Closing this as superseded by #43464 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the detection mechanism introduced in #15158 and refined in #16526 and moves all the compiler detection logic to packages. This includes finding compilers on Cray by inspection of the environment modules. To this end the
spack external findcommand has been extended with a new option--craypeand new logic to inspect Cray Programming Environments has been added.The
spack compiler findcommand has been modified to rely onspack external findfor compiler detectionModifications:
spack.compilersto builtin packagesxlcandxlfcce-classic(Cray frontend) andcce(LLVM frontend)detection_test.yamlfile living alongsidepackage.py