Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up bootstrap and architecture unit tests #33865

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

alalazo
Copy link
Member

@alalazo alalazo commented Nov 12, 2022

Trying to speed-up the slowest tests in CI:

  • The unit test in cmd/bootstrap doesn't need to concretize, since it checks only metadata for the mirror.
  • The unit test in architecture.py wasn't using the mock repository

The unit test doesn't need to concretize, since it checks
only metadata for the mirror.
@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality tests General test capability(ies) labels Nov 12, 2022
@alalazo alalazo changed the title Speed-up bootstrap mirror unit test Speed-up bootstrap and architecture unit tests Nov 12, 2022
@alalazo
Copy link
Member Author

alalazo commented Nov 12, 2022

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Nov 12, 2022

I've started that pipeline for you!

@alalazo alalazo requested review from haampie and trws November 12, 2022 21:07
@alalazo alalazo merged commit 03224e5 into spack:develop Nov 13, 2022
@alalazo alalazo deleted the ci/bootstrap_metadata_test branch November 13, 2022 12:09
charmoniumQ pushed a commit to charmoniumQ/spack that referenced this pull request Nov 19, 2022
* Speed-up bootstrap mirror unit test

The unit test doesn't need to concretize, since it checks
only metadata for the mirror.

* architecture.py: use "default_mock_concretization" for slow test
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
* Speed-up bootstrap mirror unit test

The unit test doesn't need to concretize, since it checks
only metadata for the mirror.

* architecture.py: use "default_mock_concretization" for slow test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands core PR affects Spack core functionality tests General test capability(ies)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants