streamstat: new package

[cyrush]

No description provided.

[spackbot-app]

Hi @cyrush! I noticed that the following package(s) don't yet have maintainers:

• streamstat

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["cyrush"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame streamstat

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

[tldahlgren]

Confirmed branch exists.

[tldahlgren]

@spackbot fix style

[spackbot-app]

Let me see if I can fix that for you!

[spackbot-app]

I encountered an error attempting to format style.

Details

Error: <class 'sh.ErrorReturnCode_3'>, 

  RAN: /tmp/tmp9u4rpzrn/spack-develop/bin/spack --color never style --fix --root /tmp/tmp9u4rpzrn/spack

  STDOUT:


  STDERR:

Stack trace:
  File "/usr/local/lib/python3.7/site-packages/rq/worker.py", line 1075, in perform_job
    rv = job.perform()
  File "/usr/local/lib/python3.7/site-packages/rq/job.py", line 854, in perform
    self._result = self._execute()
  File "/usr/local/lib/python3.7/site-packages/rq/job.py", line 880, in _execute
    coro_result = loop.run_until_complete(result)
  File "/usr/local/lib/python3.7/asyncio/base_events.py", line 587, in run_until_complete
    return future.result()
  File "./spackbot/workers.py", line 336, in fix_style_task
    spack, ["--color", "never", "style", "--fix", "--root", check_dir]
  File "./spackbot/helpers.py", line 164, in run_command
    raise inst
  File "./spackbot/helpers.py", line 157, in run_command
    control(*cmd, _out=res, _err=err, _ok_code=ok_codes)
  File "/usr/local/lib/python3.7/site-packages/sh.py", line 1524, in __call__
    return RunningCommand(cmd, call_args, stdin, stdout, stderr)
  File "/usr/local/lib/python3.7/site-packages/sh.py", line 788, in __init__
    self.wait()
  File "/usr/local/lib/python3.7/site-packages/sh.py", line 845, in wait
    self.handle_command_exit_code(exit_code)
  File "/usr/local/lib/python3.7/site-packages/sh.py", line 869, in handle_command_exit_code
    raise exc

[tldahlgren]

Looks like there are a number of style errors across tools.

[cyrush]

Looks like the reformat bot is not having good day. Not sure how to interpret that.

I'll look at the other output.

Also - I asked the authors to do a release with a version number b/c I think life will be to complex tied to the main branch.

[scottwittenburg]

@spackbot fix style

[spackbot-app]

Let me see if I can fix that for you!

[spackbot-app]

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, mypy, black, flake8
==> Modified files
  var/spack/repos/builtin/packages/streamstat/package.py
==> Running isort checks
Fixing /tmp/tmptlerofnd/spack/var/spack/repos/builtin/packages/streamstat/package.py
  isort checks were clean
==> Running mypy checks
lib/spack/llnl/util/lang.py:1064: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/util/timer.py:68: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/build_environment.py:291: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/bootstrap/_common.py:52: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
Success: no issues found in 571 source files
  mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/streamstat/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

But it looks like I'm not able to push to your branch. 😭️ Did you check maintainer can edit when you opened the PR?

[alalazo]

@cyrush Due to limitations on GitHub, people can't give push permissions on branches belonging to organizations (like Alpine-DAV). Therefore spackbot can't be of much help here - you need to run spack style --fix locally and push the changes.