Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward lookup of the "run_tests" attribute #34531

Merged
merged 1 commit into from Dec 15, 2022
Merged

Forward lookup of the "run_tests" attribute #34531

merged 1 commit into from Dec 15, 2022

Conversation

alalazo
Copy link
Member

@alalazo alalazo commented Dec 14, 2022

fixes #34518

Fix an issue due to the MRO chain of the package wrapper during build. Before this PR we were always returning False when the builder object was created before the run_tests method was monkey patched.

@alalazo
Forward lookup of the "run_tests" attribute
dfcea63 
fixes spack#34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
@alalazo alalazo added the bugfix label Dec 14, 2022
@spackbot-app spackbot-app bot added core PR affects Spack core functionality tests General test capability(ies) labels Dec 14, 2022
@alalazo
Copy link
Member Author

alalazo commented Dec 14, 2022

@rbberger @tvandera Can you confirm this solves your issue?

@rbberger
Copy link
Member

@alalazo I'll get back to you probably tomorrow when I had a chance to test it.

@tvandera
Copy link
Contributor

Yes, this seems to solve the issue.

@haampie haampie merged commit 7056a4b into spack:develop Dec 15, 2022
@alalazo alalazo deleted the bugfix/run_tests_old_style branch December 15, 2022 08:37
@alalazo alalazo mentioned this pull request Dec 15, 2022
Merged
20 tasks
@rbberger
Copy link
Member

@alalazo it's already merged, just wanted to confirm that is solves the issue. Thanks! :-)

@tvandera
Copy link
Contributor

Indeed, grazie molto.

benkirk pushed a commit to benkirk/spack that referenced this pull request Dec 16, 2022
@alalazo @benkirk
Forward lookup of the "run_tests" attribute (spack#34531)
cfd5d5a 
fixes spack#34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
@alalazo alalazo mentioned this pull request Dec 21, 2022
Closed
3 tasks
haampie pushed a commit that referenced this pull request Dec 22, 2022
@alalazo @haampie
Forward lookup of the "run_tests" attribute (#34531)
f8fd6e8 
fixes #34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
haampie pushed a commit that referenced this pull request Dec 23, 2022
@alalazo @haampie
Forward lookup of the "run_tests" attribute (#34531)
bc1ad41 
fixes #34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
@alalazo alalazo mentioned this pull request Jan 11, 2023
Closed
alalazo added a commit to alalazo/spack that referenced this pull request Jan 11, 2023
@alalazo
Forward lookup of "test_log_file" and "test_failures"
2614173 
refers spack#34531
closes spack#34487
fixes spack#34440
@alalazo alalazo mentioned this pull request Jan 11, 2023
Merged
tldahlgren added a commit that referenced this pull request Jan 17, 2023
@alalazo @tldahlgren
Forward lookup of "test_log_file" and "test_failures" (#34882)
74901a3 
* Forward lookup of "test_log_file" and "test_failures"
  refers #34531
  closes #34487
  fixes #34440
* Add unit test
* py-libensemble: fix tests
* Support stand-alone tests with cached files as install-time tests

Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
haampie pushed a commit that referenced this pull request Jan 18, 2023
@alalazo @haampie
Forward lookup of the "run_tests" attribute (#34531)
1a7c92a 
fixes #34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
haampie pushed a commit that referenced this pull request Jan 24, 2023
@alalazo @haampie
Forward lookup of the "run_tests" attribute (#34531)
bb5209d 
fixes #34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 24, 2023
@alalazo @tldahlgren @RikkiButler20
Forward lookup of "test_log_file" and "test_failures" (spack#34882)
af8c378 
* Forward lookup of "test_log_file" and "test_failures"
  refers spack#34531
  closes spack#34487
  fixes spack#34440
* Add unit test
* py-libensemble: fix tests
* Support stand-alone tests with cached files as install-time tests

Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
haampie pushed a commit that referenced this pull request Feb 7, 2023
@alalazo @haampie
Forward lookup of the "run_tests" attribute (#34531)
d66d7ba 
fixes #34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
alalazo added a commit that referenced this pull request Feb 7, 2023
@alalazo
Forward lookup of the "run_tests" attribute (#34531)
e964a39 
fixes #34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
nhanford pushed a commit to nhanford/spack that referenced this pull request Feb 15, 2023
@alalazo @tldahlgren @nhanford
Forward lookup of "test_log_file" and "test_failures" (spack#34882)
58442b7 
* Forward lookup of "test_log_file" and "test_failures"
  refers spack#34531
  closes spack#34487
  fixes spack#34440
* Add unit test
* py-libensemble: fix tests
* Support stand-alone tests with cached files as install-time tests

Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
@alalazo
Forward lookup of the "run_tests" attribute (spack#34531)
8fba810 
fixes spack#34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
@alalazo @tldahlgren
Forward lookup of "test_log_file" and "test_failures" (spack#34882)
2d88396 
* Forward lookup of "test_log_file" and "test_failures"
  refers spack#34531
  closes spack#34487
  fixes spack#34440
* Add unit test
* py-libensemble: fix tests
* Support stand-alone tests with cached files as install-time tests

Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
techxdave pushed a commit to Tech-XCorp/spack that referenced this pull request Feb 17, 2023
@alalazo @tldahlgren @techxdave
Forward lookup of "test_log_file" and "test_failures" (spack#34882)
ebddf80 
* Forward lookup of "test_log_file" and "test_failures"
  refers spack#34531
  closes spack#34487
  fixes spack#34440
* Add unit test
* py-libensemble: fix tests
* Support stand-alone tests with cached files as install-time tests

Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
@alalazo @tldahlgren @jmcarcell
Forward lookup of "test_log_file" and "test_failures" (spack#34882)
9961489 
* Forward lookup of "test_log_file" and "test_failures"
  refers spack#34531
  closes spack#34487
  fixes spack#34440
* Add unit test
* py-libensemble: fix tests
* Support stand-alone tests with cached files as install-time tests

Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haampie haampie haampie approved these changes

Assignees
No one assigned
Labels
bugfix core PR affects Spack core functionality tests General test capability(ies)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"self.run_tests" attribute masked by the object wrapper
4 participants
@alalazo @rbberger @tvandera @haampie