Backports 0.19.1 #33966

haampie · 2022-11-17T09:17:12Z

This reverts commit a869112.

Revamp the timer so we always have a designated begin and end. Fix a bug where the phase timer was stopped before the phase started, resulting in incorrect timing reports in timers.json.

* uninstall: fix accidental cubic complexity Currently spack uninstall runs in worst case cubic time complexity thanks to traversal during traversal during traversal while collecting the specs to be uninstalled. Also brings down the number of error messages printed to something linear in the amount of matching specs instead of quadratic.

Avoid text decoding and encoding when combining log files, instead combine in binary mode. Also do a buffered copy which is sometimes faster for large log files.

refers #33985

* Add a regression test for 33928 * PackageBase should not set `(build|install)_time_test_callbacks` * Fix audits by preserving the current semantic Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>

fixes #34518 Fix an issue due to the MRO chain of the package wrapper during build. Before this PR we were always returning False when the builder object was created before the run_tests method was monkey patched.

…g build env (#34059) This fixes an issue introduced in #32340, which changed the semantics of the "module" object passed to the "setup_dependent_package" callback.

fixes #34489 Customize sys.excepthook to raise SystemExit when any unhandled exception reaches the hook.

These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs

The code in FileCache for write_transaction attempts to delete the temporary file when an exception occurs under the context by calling shutil.rmtree. However, rmtree only operates on directories while the rest of FileCache uses normal files. This causes an empty file to be written to the cache key when unneeded. Use os.remove instead which operates on normal files. Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>

spack mirror create cannot work with urls, so it shouldn't promote local paths to file urls.

#34375)

Currently we print 3 lines of "file exist" warning per tarball, this is a bit excessive. Instead, it can be a simple single-line tty.warn message.

Since legit regular expressions are matched, do not pass string=True to the filter Refs #34897

At least with ZSH, prefix inspections containing `./bin` result in a `$PREFIX/./bin` and result in strange `$PATH` handling. I.e., `module load git` will prepend `/path/to/git/./bin`, `which git` will find the right executable, but `git --version` will print the system one. Normalize the relative path to avoid this behavior. See also #31867.

spackbot-app bot added core PR affects Spack core functionality documentation Improvements or additions to documentation tests General test capability(ies) utilities labels Nov 17, 2022

haampie force-pushed the backports/v0.19.1 branch from 7683bfc to 5158152 Compare November 17, 2022 11:27

spackbot-app bot added the commands label Nov 21, 2022

spackbot-app bot added build-systems build-environment labels Dec 22, 2022

haampie force-pushed the backports/v0.19.1 branch from d89c746 to fac6b56 Compare December 23, 2022 09:53

haampie added this to the v0.19.1 milestone Dec 23, 2022

haampie force-pushed the backports/v0.19.1 branch from 669b586 to fac6b56 Compare December 23, 2022 10:08

alalazo mentioned this pull request Jan 16, 2023

libtool is not filtered with Fujitsu compilers are used #34897

Closed

3 tasks

haampie force-pushed the backports/v0.19.1 branch 3 times, most recently from 2eb6ce7 to b43987c Compare January 18, 2023 12:42

spackbot-app bot added workflow binary-packages labels Jan 18, 2023

haampie force-pushed the backports/v0.19.1 branch 3 times, most recently from fb049db to e911fa3 Compare January 25, 2023 09:26

spackbot-app bot added the gitlab Issues related to gitlab integration label Feb 7, 2023

haampie and others added 9 commits February 7, 2023 10:48

Set version to 0.19.1.dev0

09ed3b0

Revert "Hotfix/namespace (#33870)"

edd62c8

This reverts commit a869112.

docs: fix typo in multiple build systems

3c3b4df

docs: fix typo (#33926)

204b45f

Fix incorrect timer (#33900)

0e0e2c0

Revamp the timer so we always have a designated begin and end. Fix a bug where the phase timer was stopped before the phase started, resulting in incorrect timing reports in timers.json.

Fixup: start the timer before the phase (#33917)

9c4d70b

Fix a bug/typo in a config_values.py fixture (#33886)

8cfc071

ci: restore ability to reproduce gitlab job failures (#33953)

9f8266a

haampie and others added 17 commits February 7, 2023 10:48

Fix combine_phase_logs text encoding issues (#34657)

dca74e6

Avoid text decoding and encoding when combining log files, instead combine in binary mode. Also do a buffered copy which is sometimes faster for large log files.

Improve error message for requirements (#33988)

45cfd43

refers #33985

PackageBase should not define builder legacy attributes (#33942)

0488714

* Add a regression test for 33928 * PackageBase should not set `(build|install)_time_test_callbacks` * Fix audits by preserving the current semantic Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>

scons: fix signature for install_args (#34481)

c7ad46c

Forward lookup of the "run_tests" attribute (#34531)

d66d7ba

fixes #34518 Fix an issue due to the MRO chain of the package wrapper during build. Before this PR we were always returning False when the builder object was created before the run_tests method was monkey patched.

Use a module-like object to propagate changes in the MRO, when settin…

d88c13d

…g build env (#34059) This fixes an issue introduced in #32340, which changed the semantics of the "module" object passed to the "setup_dependent_package" callback.

Propagate exceptions from Spack python console (#34547)

a479f17

fixes #34489 Customize sys.excepthook to raise SystemExit when any unhandled exception reaches the hook.

docs: remove monitors and analyzers (#34358)

6530e63

These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs

spack mirror create takes local paths only (#34992)

c994916

spack mirror create cannot work with urls, so it shouldn't promote local paths to file urls.

disable flake warnings for unused imports of types

bb76195

Bug fix for duplicate rpath errors on macOS when creating build caches (

039b59b

#34375)

no python 3.6 anymore on ubuntu 22.04 in relevant setup action?

66bca6a

buildcache create: make "file exists" less verbose (#35019)

c067ef2

Currently we print 3 lines of "file exist" warning per tarball, this is a bit excessive. Instead, it can be a simple single-line tty.warn message.

fix libtool filter for Fujitsu compilers (#34916)

7224fc1

Since legit regular expressions are matched, do not pass string=True to the filter Refs #34897

e4s: disable mac stack due to binary relocation issue#32571 (#34560)

ab1419c

haampie force-pushed the backports/v0.19.1 branch from cc8cf41 to ab1419c Compare February 7, 2023 09:49

Set version to 0.19.1

dd788ba

haampie force-pushed the backports/v0.19.1 branch from dd1b6c0 to dd788ba Compare February 7, 2023 14:05

alalazo approved these changes Feb 7, 2023

View reviewed changes

alalazo merged commit 0d26a4a into releases/v0.19 Feb 7, 2023

alalazo deleted the backports/v0.19.1 branch February 7, 2023 19:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backports 0.19.1 #33966

Backports 0.19.1 #33966

haampie commented Nov 17, 2022 •

edited

Backports 0.19.1 #33966

Backports 0.19.1 #33966

Conversation

haampie commented Nov 17, 2022 • edited

haampie commented Nov 17, 2022 •

edited