Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-onnxruntime: new version 1.1[1234].1 #37064

Closed
wants to merge 2 commits into from

Conversation

wdconinc
Copy link
Contributor

Needed for acts@23.3: #37055.

I suspect the statement "supports all ONNX releases with both future and backwards compatibility" isn't going to result in this being a matter of simply adding the new versions, but it's a start... (hence draft).

Already noticed patch("cms_1_10.patch", whe="@1.10") with typo.

@@ -52,7 +56,7 @@ class PyOnnxruntime(CMakePackage, PythonExtension):
# https://github.com/cms-externals/onnxruntime/compare/5bc92df...d594f80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py-coloredlogs is required now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this has been a difficult one to get working. I have 15.1.0 working, but not yet any of the intermediate versions...

@wdconinc
Copy link
Contributor Author

Fails to compile (for 1.11.1 at least) due to missing nsync_cpp library.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the four version tags.

@wdconinc
Copy link
Contributor Author

Obsolete by #43062.

@wdconinc wdconinc closed this Apr 13, 2024
@wdconinc wdconinc deleted the patch-33 branch April 13, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants