Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-earth2mip: add new package #43062

Merged
merged 18 commits into from Mar 11, 2024

Conversation

adamjstewart
Copy link
Member

No description provided.

Copy link

spackbot-app bot commented Mar 6, 2024

Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

  • magics
  • py-colabtools
  • py-ecmwf-opendata
  • py-ecmwflibs
  • py-flax
  • py-graphcast
  • py-jraph
  • py-multiurl
  • py-nvidia-modulus
  • py-nvtx
  • py-orbax-checkpoint
  • py-properscoring
  • py-pytest-regtest
  • py-tensorstore
  • py-tree
  • py-treelib
  • py-triton
  • py-xhistogram
  • py-xskillscore

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("adamjstewart")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame magics

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@spackbot-app spackbot-app bot requested review from jcpunk and skosukhin March 6, 2024 21:16
tldahlgren
tldahlgren previously approved these changes Mar 7, 2024
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new homepages and version sha256s/commits. Rest LGTM.

@tldahlgren tldahlgren enabled auto-merge (squash) March 7, 2024 17:42
@tldahlgren tldahlgren self-assigned this Mar 7, 2024
@tldahlgren tldahlgren disabled auto-merge March 7, 2024 17:42
@tldahlgren
Copy link
Contributor

@jcpunk @skosukhin Do you want to comment on this PR before it is merged?

@adamjstewart adamjstewart marked this pull request as draft March 8, 2024 09:58
@adamjstewart
Copy link
Member Author

Down to only 2 remaining build issues: onnxruntime and tensorstore

@adamjstewart adamjstewart marked this pull request as ready for review March 8, 2024 15:53
@adamjstewart
Copy link
Member Author

Okay, everything builds now.

@jcpunk
Copy link
Contributor

jcpunk commented Mar 8, 2024

No objection from me.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-confirmed homepages and version directives.

@tldahlgren tldahlgren merged commit 98162aa into spack:develop Mar 11, 2024
13 checks passed
@adamjstewart adamjstewart deleted the packages/py-earth2mip branch March 11, 2024 21:12
mathomp4 pushed a commit to mathomp4/spack that referenced this pull request Mar 27, 2024
* py-earth2mip: add new package

* Fix audit tests

* Make things easier to concretize

* Make things easier to concretize

* Fix magics build

* Fix onnx build

* blacken

* cmake > py-cmake

* Fix onnxruntime build

* onnxruntime: remove unknown cmake vars

* Trick bazelisk into using Spack bazel

* Different deps for main

* protobuf: add v3.25.3

* Enforce upper bound on jaxlib version

* py-chex: add v0.1.85

* py-dm-haiku: add v0.0.12

* py-jax: add v0.4.25

* Older jaxlib doesn't build on ppc64le either
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants