Bugfix: allow preferred new versions from externals #37747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
core
|
@scheibelp This works for me. |
alalazo
reviewed
May 17, 2023
haampie
approved these changes
May 18, 2023
haampie
pushed a commit
that referenced
this pull request
May 18, 2023
alalazo
pushed a commit
that referenced
this pull request
May 18, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by #37687
Allow adding a preference for a version defined in an external, even if that version doesn't appear in the
package.py.See: #37733 (comment)
In asp.py, this moves version collection related to preferences/requirements until after external packages are defined. The other option that occurs to me is to collect any version unique to the preferences/requirements and then verify after external packages are defined, but there doesn't seem to be anything important about the original order (or for example defining versions before variants).