Improve buildcache sync and parallelize #39008
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide option to only sync buildcache entries that are properly signed. Also, gracefully ignore any entries from the manifest that did not get created created in the pipeline. Add tests of new and previously untested code paths.
spackbot-app
bot
added
commands
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype that builds on #38866 to parallelize the version of
spack buildcache syncthat syncs all environment specs from one mirror to another.Working on this, I noticed that using Stage/FetchStrategy does not parallelize well, and results in files that end up in the wrong stage directories. I'm not 100% sure, but I suspect there is not a 1-1 relationship between them (many stages share a fetch strategy, and each one says
fetcher.stage = this), making Stage not thread-safe. At least not the way I was using it. So this PR removes the use of Stage for fetching buildcache files.Still todo on this PR would include:
--manifest-globpath, since that's what is used currently in spackprotected-publishjobs