spack.util.web: add copy api #39009
Draft
spack.util.web: add copy api #39009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide option to only sync buildcache entries that are properly signed. Also, gracefully ignore any entries from the manifest that did not get created created in the pipeline. Add tests of new and previously untested code paths.
spackbot-app
bot
added
commands
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype that builds on #39008 and #38866 to further speed up
spack buildcache sync. By using low-level S3 client api supporting direct copying from one bucket/prefix to another, this PR avoids the current approach of copying (download the file locally, then push it to the remote destination).There would still be a lot to do on this PR:
copymethodCurrently I am testing this on S3 mirrors using these scripts. I also used those scripts to test #39008 and #38866, by doing environment aware buildcache sync of all stacks for develop snapshot pipelines from the stack-specific pipeline mirrors to the root. With no parallelization (#38866), syncing one develop snapshot to the top-level mirror took 16 hrs 馃槺, adding parallelization (#39008) reduced that to 8 hrs, and this PR reduced the time spent to just over 45 minutes.