Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new pkg] add zfit-physics pkg #43696

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jonas-eschle
Copy link
Contributor

zfit-physics is a pure Python package with extensions to the already available zfit

requires #43695

Copy link

spackbot-app bot commented Apr 16, 2024

@ikrommyd can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • py-zfit-physics

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the homepage BUT fetching is failing so cannot confirm the sha256.

@tldahlgren tldahlgren self-assigned this Apr 18, 2024
@jonas-eschle
Copy link
Contributor Author

Confirmed the homepage BUT fetching is failing so cannot confirm the sha256.

fixed a typo, now it should work

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not able to check the sha256 or even stage the package (without the recommended change).

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can now confirm the sha256. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants