Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: add py-hepstats package #43697

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

jonas-eschle
Copy link
Contributor

add the hepstats package. Requires #43695

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this package needs a bit of work.

var/spack/repos/builtin/packages/py-hepstats/package.py Outdated Show resolved Hide resolved
@tldahlgren tldahlgren self-assigned this Apr 17, 2024
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't confirm sha256 or stage the package.

var/spack/repos/builtin/packages/py-hepstats/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-hepstats/package.py Outdated Show resolved Hide resolved
@jonas-eschle
Copy link
Contributor Author

While I think the pypi works now (?) after going back and forth, I've encountered the following error when building:

==> py-hepstats: Executing phase: 'install'
==> Error: AttributeError: 'super' object has no attribute 'install'

The 'py-hepstats' package cannot find an attribute while trying to build from sources. This might be due to a change in Spack's package format to support multiple build-systems for a single package. You can fix this by updating the build recipe, and you can also report the issue as a bug. More information at https://spack.readthedocs.io/en/latest/packaging_guide.html#installation-procedure

/workdir/spack/lib/spack/spack/builder.py:147, in __getattr__:
        146        def __getattr__(self, item):
  >>    147            result = getattr(super(type(self.root_builder), self.root_builder), item)
        148            if item in super(type(self.root_builder), self.root_builder).phases:
        149                result = _PhaseAdapter(self.root_builder, result)
        150            return result

I cannot make any sense of it, @tldahlgren , any ideas?

@tldahlgren
Copy link
Contributor

tldahlgren commented Apr 23, 2024

While I think the pypi works now (?) after going back and forth, I've encountered the following error when building:

==> py-hepstats: Executing phase: 'install'
==> Error: AttributeError: 'super' object has no attribute 'install'

The 'py-hepstats' package cannot find an attribute while trying to build from sources. This might be due to a change in Spack's package format to support multiple build-systems for a single package. You can fix this by updating the build recipe, and you can also report the issue as a bug. More information at https://spack.readthedocs.io/en/latest/packaging_guide.html#installation-procedure

/workdir/spack/lib/spack/spack/builder.py:147, in __getattr__:
        146        def __getattr__(self, item):
  >>    147            result = getattr(super(type(self.root_builder), self.root_builder), item)
        148            if item in super(type(self.root_builder), self.root_builder).phases:
        149                result = _PhaseAdapter(self.root_builder, result)
        150            return result

I cannot make any sense of it, @tldahlgren , any ideas?

I am unable to reproduce the problem (because I'm getting a number of packages that are having problems with finding python.h).

Perusing the sources, I don't see how this can be happening for that package and I'm not seeing any commits since your update that stand out as having this effect.

Please submit an issue with the requested information.

@jonas-eschle
Copy link
Contributor Author

A clean install... magically made it work. I can confirm now that it builds (the extra, which is off by default, requires zfit, PR here: #43695, that's why the CI is failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants