dla-future-fortran: new package #44314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasolca
approved these changes
May 22, 2024
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/dla-future-fortran/package.py
==> Running isort checks
Fixing /tmp/tmp4_o6hhwz/spack/var/spack/repos/builtin/packages/dla-future-fortran/package.py
isort checks were clean
==> Running black checks
All done! ✨ 🍰 ✨
1 file left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
Found 3 errors in 1 file (checked 625 source files)
mypy found errors
I've updated the branch with style fixes. |
msimberg
previously approved these changes
May 22, 2024
aurianer
reviewed
May 23, 2024
haampie
reviewed
May 23, 2024
RMeli
commented
May 23, 2024
alecbcs
changed the title
msimberg
approved these changes
May 24, 2024
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
* Spglib: add version 2.4.0 * dla-future-fortran: new package version 0.1.0 * [@spackbot] updating style on behalf of RMeli * apply suggestion and add maintainer --------- Co-authored-by: RMeli <RMeli@users.noreply.github.com>
hariharan-devarajan
pushed a commit
to hariharan-devarajan/spack
that referenced
this pull request
Jul 10, 2024
* Spglib: add version 2.4.0 * dla-future-fortran: new package version 0.1.0 * [@spackbot] updating style on behalf of RMeli * apply suggestion and add maintainer --------- Co-authored-by: RMeli <RMeli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fortran interface for DLA-Future.
https://github.com/eth-cscs/DLA-Future-Fortran/releases/tag/v0.1.0