update filename used for cc wrapper invocation debug log #5837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed that the cc wrapper also uses |
…for build details in that. Add a new variable to store a filename-compatible format of the spec name.
I restored how |
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Nov 13, 2017
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Dec 1, 2017
kljohann
added a commit
to electronicvisions/spack
that referenced
this pull request
Dec 4, 2017
scheibelp
pushed a commit
that referenced
this pull request
Dec 11, 2017
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Dec 15, 2017
ch741
pushed a commit
to ch741/spack
that referenced
this pull request
Apr 20, 2018
Fixes spack#6521. Bazel's build system filters environment variables, including those set by Spack for use by its compiler wrapper. This updates the patch to include the SPACK_DEBUG_LOG_ID variable added in spack#5837.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the debug log written by the cc compiler wrapper is given by
Spec.short_spec, which includes the architecture. Somewhere along the lineSpec.formatstarted adding spaces around the architecture property so the filename started including spaces; the cc wrapper script appears to ignore this, so files likespack-cc-bzip2-....in.log(which record the wrapped compiler invocations) were not being generated.This updates the value ofSPACK_SHORT_SPECto a value without spaces (just includes the name and hash).EDIT: the original value of
SPACK_SHORT_SPECwas important so I added a new variable to store the identifier used to generate log file names (SPACK_DEBUG_LOG_ID).