Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -d option to diy to specify source path move -j to common args #5963

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

krafczyk
Copy link
Contributor

It seems that #5043 is currently stalled which was the primary location changes from #2771 were supposed to go.

Rather than continue this, I've made a new PR with these changes adopted to the current develop branch.

Once this is merged, I'll close #2771.

@krafczyk
Copy link
Contributor Author

@luigi-calori this is PR #2771 adopted to the current develop branch. If you're still interested in using these changes.

@luigi-calori
Copy link
Contributor

Thank you very much, I' m currently using it and would like it to be merged

@krafczyk
Copy link
Contributor Author

krafczyk commented Nov 8, 2017

@tgamblin This change has been sitting around for a while, it sounds like it's useful, can we get it merged?

@luigi-calori
Copy link
Contributor

I' m currently using and confirm it works. Would like it to be merged, It seems that codecov test are failing: any idea how to fix?

@alalazo alalazo mentioned this pull request Nov 21, 2017
@luigi-calori
Copy link
Contributor

Sorry to bother but this is conflicting again. Any hope to have it merged?

I'm specifically using the ability to specify a source folder
(I want to do development work inside a git working copy: the code is composed of python scripts, the "install" in dev mode is just a symlink to sources)

Is there a workaround like specifying install --source with git deployment?
my current workflow is:

git clone <my_git_url> <my_package_working_copy>
spack diy -d <my_package_working_copy> my_package

Thanks for any hints

@krafczyk
Copy link
Contributor Author

@luigi-calori I'm not aware of other methods to use an external directory as a source code location from which spack builds a package.

I've been waiting for folks to merge this, but they haven't gotten around to it..

I'll bother them again.

@krafczyk
Copy link
Contributor Author

@tgamblin @alalazo Can we get this merged yet? Its been quite some time and people such as myself and @luigi-calori use it in our workflows.

@adamjstewart adamjstewart merged commit 1b38631 into spack:develop Apr 18, 2018
@adamjstewart
Copy link
Member

Sorry it's taken so long to get this merged! Feel free to ping me on any other old PRs lying around. I don't normally like to merge non-package-related PRs myself, but it sounds like a lot of people are using this one, so I'm not too worried.

citibeth pushed a commit to citibeth/spack that referenced this pull request Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants