-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -d option to diy to specify source path move -j to common args #5963
Conversation
@luigi-calori this is PR #2771 adopted to the current |
Thank you very much, I' m currently using it and would like it to be merged |
@tgamblin This change has been sitting around for a while, it sounds like it's useful, can we get it merged? |
I' m currently using and confirm it works. Would like it to be merged, It seems that codecov test are failing: any idea how to fix? |
Sorry to bother but this is conflicting again. Any hope to have it merged? I'm specifically using the ability to specify a source folder Is there a workaround like specifying install --source with git deployment? git clone <my_git_url> <my_package_working_copy> Thanks for any hints |
0a59ab4
to
b373cb0
Compare
@luigi-calori I'm not aware of other methods to use an external directory as a source code location from which spack builds a package. I've been waiting for folks to merge this, but they haven't gotten around to it.. I'll bother them again. |
@tgamblin @alalazo Can we get this merged yet? Its been quite some time and people such as myself and @luigi-calori use it in our workflows. |
Sorry it's taken so long to get this merged! Feel free to ping me on any other old PRs lying around. I don't normally like to merge non-package-related PRs myself, but it sounds like a lot of people are using this one, so I'm not too worried. |
It seems that #5043 is currently stalled which was the primary location changes from #2771 were supposed to go.
Rather than continue this, I've made a new PR with these changes adopted to the current
develop
branch.Once this is merged, I'll close #2771.