Production update to db.sql due to MariaDB upgrade #37
Conversation
| `DialogName` varchar(200) NOT NULL DEFAULT '', | ||
| `LanguageCode` char(2) NOT NULL DEFAULT '', | ||
| `DialogText` text, | ||
| `DialogType` smallint(6) NOT NULL DEFAULT '0', | ||
| `DialogText` text DEFAULT NULL, |
There was a problem hiding this comment.
This is actually not just a change due to a MariaDB upgrade. It seems to stand by itself, possibly some kind of bugfix.
|
Generally happy with this patch - most of the changes are just due to MySQL dumping integers rather than strings equivalent to integers which is better SQL anyway. The other ones I noticed are obvious improved defaults. Recommend merge ASAP. |
| `ExpireTime` bigint(20) unsigned DEFAULT NULL, | ||
| PRIMARY KEY (`EmailID`), | ||
| KEY `UserID` (`UserID`,`Word`,`Count`), | ||
| KEY `Word` (`Word`) | ||
| ) ENGINE=MyISAM AUTO_INCREMENT=8443939 DEFAULT CHARSET=latin1; | ||
| ) ENGINE=MyISAM AUTO_INCREMENT=9212076 DEFAULT CHARSET=latin1; |
There was a problem hiding this comment.
This new number seems related to the existing dataset size instead of being required to recreate the DB. While it is fine to start the next EmailID at 9212076 this change (and some future point, this line) can be ommitted. That said, there is no harm in keeping this change for preserving the changes.
There was a problem hiding this comment.
(similar comment for other occurences)
jgonggrijp
force-pushed
the
update-mariadb
branch
from
4e2a1d9
to
ad87934
Compare
jgonggrijp
changed the title
This change reflects formatting, version and state changes to the db.sql that occurred on the production server. It is the first commit of #33. Merging this will bring
mastercloser to what's running in production.