fix: don't match a trailing period after the path #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spamscanner#17. This also extends `trailingPeriod: false` (the default) to exclude matching a trailing question mark (?) or exclamation mark (!). That is if you want "Check out example.com/project." to NOT match the trailing period, you typically also want it to NOT match the trailing exclamation mark in "Check out example.com/project!". Likewise for "Have you seen example.com/project?". I guess technically `trailingPeriod` should be renamed `trailingPunctuation` but maybe it's fine as-is?
|
Amazing work! 🙏 Thank you! |
|
Publishing now, one moment |
|
v4.0.0 released with this, thank you @birtles release notes @ https://github.com/spamscanner/url-regex-safe/releases/tag/v4.0.0 note: this version now requires node v14+ |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17.
This also extends
trailingPeriod: false(the default) to excludematching a trailing question mark (?) or exclamation mark (!).
That is if you want "Check out example.com/project." to NOT match the
trailing period, you typically also want it to NOT match the trailing
exclamation mark in "Check out example.com/project!".
Likewise for "Have you seen example.com/project?".
I guess technically
trailingPeriodshould be renamedtrailingPunctuationbut maybe it's fine as-is?Checklist