Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of the transitive dependency Optimal #33

Merged
merged 3 commits into from
Sep 25, 2021

Conversation

kamilkowalski
Copy link
Contributor

Relates to spandex-project/spandex#124. Currently spandex_datadog makes use of Optimal even though it doesn't list it as a dependency - it's only available because spandex requires it, and spandex_datadog requires spandex. This removes the use of Optimal, as we think it is the way to go for Spandex to be fast.

Copy link
Member

@GregMefford GregMefford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Since we're only validating the params in start_link, this change itself won't break any existing code (it would have to already be broken to make a difference), but now that we're not validating the opts, it's possible that someone could configure invalid opts and cause a crash somewhere else where it might be less obvious what the problem is.

I'm thinking that we can bundle this change with the re-work of the ApiServer (#32) together and release a new major/minor version once we figure out what all the changes will look like.

@kamilkowalski
Copy link
Contributor Author

Awesome! That PR looks interesting - together with removing Optimal could boost performance significantly.

@GregMefford
Copy link
Member

Thanks again for taking the time to create this PR and sorry it took so long to get it merged! 🎈 🚀

@GregMefford GregMefford merged commit 459d217 into spandex-project:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants