Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hookshot - Generic webhooks will be routed to /webhook #1681

Closed
Half-Shot opened this issue Mar 7, 2022 · 2 comments
Closed

Hookshot - Generic webhooks will be routed to /webhook #1681

Half-Shot opened this issue Mar 7, 2022 · 2 comments

Comments

@Half-Shot
Copy link

Currently hookshot generic webhooks get routed to /:hookId on the webhooks listener, but matrix-org/matrix-hookshot#227 is chaging things so we now prefer them to be routed to /webhook/:hookId. While previous setups still work, it's deprecated behavior.

@HarHarLinks
Copy link
Contributor

I'll work on this

HarHarLinks added a commit to HarHarLinks/matrix-docker-ansible-deploy that referenced this issue Mar 31, 2022
spantaleev added a commit that referenced this issue Jun 25, 2024
By appending `/webhook` to the public URL (becoming `/hookshot/webhooks/webhook`)
and by only stripping the `/hookshot/webhooks` prefix,
we're effectively following what newer Hookshot versions advise
(see #1681).

This change appears to be backward-compatible (old webhook URLs like `/hookshot/webhooks/:hookId` still work),
until Hookshot behavior changes.
@spantaleev
Copy link
Owner

Fixed by 4704a60

venimus pushed a commit to superhero-com/matrix-docker-ansible-deploy that referenced this issue Jul 3, 2024
By appending `/webhook` to the public URL (becoming `/hookshot/webhooks/webhook`)
and by only stripping the `/hookshot/webhooks` prefix,
we're effectively following what newer Hookshot versions advise
(see spantaleev#1681).

This change appears to be backward-compatible (old webhook URLs like `/hookshot/webhooks/:hookId` still work),
until Hookshot behavior changes.
venimus pushed a commit to superhero-com/matrix-docker-ansible-deploy that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants