matrix-bot-honoroit: disable self-build by default, update to v0.9.1 #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one more thing: closes #1518 |
spantaleev
reviewed
Jan 9, 2022
|
seems like CI lint is broken, but local lint doesn't show any issues |
|
We should get rid of that (well, or make it not fragile). Not sure why it's acting up when we've supposedly pinned it to a specific commit and versionz |
|
The problem is not with ansible-lint itself, but with one of subpackages. Seems like it has dependencies defined without pin to minor and/or patch versions: Could you merge the PR, please? |
|
Merged! Thanks! 👍 |
spantaleev
added a commit
that referenced
this pull request
Jan 10, 2022
Related to #1488 Discussed here: - #1522 (comment) - #1524 (comment)
HarHarLinks
pushed a commit
to HarHarLinks/matrix-docker-ansible-deploy
that referenced
this pull request
Feb 16, 2022
Related to spantaleev#1488 Discussed here: - spantaleev#1522 (comment) - spantaleev#1524 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
To mitigate #1518 and prevent such issues in future, multiarch support was added both to the base image and to the honoroit image.
Both images support arm32, arm64 and amd64 architectures now, so no need for automatic self-building (of course, that's still possible, but default value changed to
false).These changes already available for the
latestimage tag, but as it works as expected, pinned release added as well.