Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG - Step 2B: Calendar Query and Rendering Need Improvement Part 2 - Visit Groups #962

Merged
merged 7 commits into from Jul 11, 2017

Conversation

kayla-glick
Copy link
Contributor

Pivotal:
https://www.pivotaltracker.com/story/show/147047673

Tasks:

  1. Optimize the VisitGroupsController#update action by rerendering only the necessary information. (In this case, that's the Visit Group in the calendar header and the page select).

  2. While doing 1, I discovered that the page select was not working for #view_full_calendar and #merged_calendar. This is because we used the #table action to rerender when clicked. Added conditions to the link to use the correct path and added variables.

  3. Pages were not storing properly. There was ambiguity between ints and strings in the arm ids and page numbers that was causing inconsistency in the controller. I converted the general format to use ints.

  4. Sometimes several parameters were not being passed at all (especially pages). Included correct variables to be passed to allow proper rerendering.

@kayla-glick kayla-glick changed the base branch from master to v3.0.0 July 6, 2017 18:52
@Stuart-Johnson Stuart-Johnson merged commit ffb7af2 into v3.0.0 Jul 11, 2017
@Stuart-Johnson Stuart-Johnson deleted the kg-calendar_optimization_pt_2 branch July 11, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants