KG - Step 2B: Calendar Query and Rendering Need Improvement Part 2 - Visit Groups #962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal:
https://www.pivotaltracker.com/story/show/147047673
Tasks:
Optimize the
VisitGroupsController#update
action by rerendering only the necessary information. (In this case, that's the Visit Group in the calendar header and the page select).While doing 1, I discovered that the page select was not working for
#view_full_calendar
and#merged_calendar
. This is because we used the#table
action to rerender when clicked. Added conditions to the link to use the correct path and added variables.Pages were not storing properly. There was ambiguity between ints and strings in the arm ids and page numbers that was causing inconsistency in the controller. I converted the general format to use ints.
Sometimes several parameters were not being passed at all (especially
pages
). Included correct variables to be passed to allow proper rerendering.