Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG - Revert #992 for v3.0.0 Refactors #995

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

kayla-glick
Copy link
Contributor

@kayla-glick kayla-glick commented Jul 12, 2017

#992 Pivotal:
https://www.pivotaltracker.com/story/show/148590319

#962 merged for v3.0.0 fixes an issue which caused the visits select dropdown to always render ServiceCalendarsController#table.js by adding conditional logic to determine which JS route to use, corresponding to the calendar's original route. In other words, #table should rerender #table, #merged_calendar should rerender #merged_calendar and #view_full_calendar should rerender #view_full_calendar.

The referenced code change in #962:
app/views/service_calendars/master_calendar/pppv/_visit_group_page_select.html.haml
Original

- path_method = method(:table_service_calendars_path)

Updated

- if consolidated
  - path_method = method(:view_full_calendar_service_calendars_path)
- elsif merged
  - path_method = method(:merged_calendar_service_calendars_path)
- else
  - path_method = method(:table_service_calendars_path)

@kayla-glick kayla-glick changed the title KG - Revert #992 for 3.0.0 Refactors KG - Revert #992 for v3.0.0 Refactors Jul 12, 2017
@Stuart-Johnson Stuart-Johnson merged commit 2b6b22d into v3.0.0 Jul 13, 2017
@Stuart-Johnson Stuart-Johnson deleted the kg-extra_service_calendar_table_logic branch July 13, 2017 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants