GitHub Actions Windows Examples Fix #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardasener
added
state: review needed
type: fix
AmroAlJundi
approved these changes
May 19, 2022
AmroAlJundi
added
state: approved
SinanEkm
pushed a commit
that referenced
this pull request
Aug 19, 2024
GitHub Actions Windows Examples Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the example codes are built in Windows, they are automatically given a
.exeextension. As a result therun_all_examples.pyscript used by Github Actions ignored these executables since their names did not match what was expected. This PR should fix that issue.