Docs and Tests for I/O #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementations, fixed Binary IO issues, added docs for readers
…ew EdgeListReader
…ering tutorial page
# Conflicts: # tests/CMakeLists.txt
ardasener
added
type: docs
…l fix to Graph dimensions when constructed from a file
AmroAlJundi
reviewed
May 20, 2022
AmroAlJundi
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will add a test suite and documentation comments for the members of
sparsebase::utils::ionamespace. It also includes a number of fixes to the Reader/Writer classes.The test suites involve writing hard coded mtx and edge list data into files and reading them using sparsebase's Reader classes, checking the integrity and dimensions of the data after the read.
BinaryReader and BinaryWriter classes were harder to test as the file format used is unique to sparsebase. These tests simply write some hard coded matrices to files and the read them back expecting the read matrix to be identical to the original one. Tests in the
writer_tests.ccfile are just copies of the ones inreader_tests.cc. This separate file is included to make future organization easier.