-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-type conversion, cached base functions, Contexts mutable once, casting FormatOrderX without templates, casting Permute
outputs is optional
#194
Conversation
…_context_oncemutable # Conflicts: # src/sparsebase/format/format.h # tests/suites/sparsebase/format/format_tests.cc
Will add two additional features over the PR. |
…_context_oncemutable # Conflicts: # src/sparsebase/format/format.h # src/sparsebase/preprocess/preprocess.h
Permute
outputs is optional
…_context_oncemutable # Conflicts: # src/generate_explicit_instantiations.py # src/sparsebase/preprocess/preprocess.h # tests/suites/sparsebase/preprocess/preprocess_tests.cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue related to As -> AsAbsolute conversion in docs (for example see line 216 in the getting_started/usage
page). I am approving this PR now since we will likely do a major overhaul to the docs and these problems can be fixed there.
…_cached_base_context_oncemutable Cross-type conversion, cached base functions, Contexts mutable once, casting FormatOrderX without templates, casting `Permute` outputs is optional
Applied changes presented in issues #147 , #177 , #168, #198 and #193. More specifically:
FormatOrderTwo
andFormatOrderOne
that is templated on the output types (functor rather than function so we can partially initialize it). The generic functor does not compile.TypeConverter
function for that class and implemented it.Convert
function that takes a format class and types toFormatOrderOne
andFormatOrderTwo
that uses the functors above.ReorderBase
andGraphFeatureBase
functions.