Docs and Tests for Converter #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e columns and rows
…n converters are removed
… changed the to_contexts vector to a reference
…c one, fixed the m/nnz bug in converters
ardasener
added
type: docs
AmroAlJundi
reviewed
May 18, 2022
AmroAlJundi
reviewed
May 18, 2022
AmroAlJundi
reviewed
May 18, 2022
AmroAlJundi
reviewed
May 18, 2022
AmroAlJundi
reviewed
May 18, 2022
AmroAlJundi
suggested changes
May 18, 2022
AmroAlJundi
reviewed
May 19, 2022
AmroAlJundi
approved these changes
May 19, 2022
SinanEkm
pushed a commit
that referenced
this pull request
Aug 19, 2024
Docs and Tests for Converter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will add a test suite and documentation comments for the members of
sparsebase::utils::converternamespace. It also includes a fix concerning conversion of certain types of matrices.The test suite uses a non-symmetric and weighted matrix for testing. The matrix was originally constructed as a COO, and a known good CSR conversion is obtained using the Scipy Python library. Using this matrix CSR->COO and COO->CSR conversions are tested. These tests simply convert the matrix using our
ConverterOrderTwoclass and compare the results to the Scipy conversion. They also check that the data is actually deep copied and not just moved. Additionally, the move converters are also checked where certain arrays should be shallow copied.The test matrix is hard coded into the test file. This is to avoid using the I/O system which will be tested separately.