Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstract class descendants not inheriting custom connection #2

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

codygustafson
Copy link

Fix thiagopradi#219

I'm adding this in to our REPO to fix what was laid out in the original branch.

@codygustafson codygustafson merged commit 7d38b42 into db2-party-time2016 Sep 5, 2019
@codygustafson codygustafson deleted the fix-abstract-classes branch September 5, 2019 02:08
@joshcom
Copy link

joshcom commented Sep 5, 2019

Boy, we are far behind! Makes sense though, great find.

@codygustafson
Copy link
Author

Yeah, I'm looking into what would prevent us from upgrading our version here. As far as I can tell a lot of our fixes have been implemented in different ways in the official gem.

@wlmcewen wlmcewen requested a review from calh September 5, 2019 14:12
@calh
Copy link

calh commented Sep 5, 2019

(I'm working with Cody right now on trying out my master branch of Octopus with all of my fun fixes)

@wlmcewen
Copy link

wlmcewen commented Sep 5, 2019

I believe @calh has actually been using the official gem and reporting issues he's encountered with DB2 specifically.

thiagopradi#531
thiagopradi#538
thiagopradi#526

@wlmcewen
Copy link

wlmcewen commented Sep 5, 2019

LGTM. To be clear, I have no opposition to moving to the latest version, especially with the tons of work Cal has put in working with this gem there.

codygustafson pushed a commit that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants