feat: Upgrading to CircleCI API v1 #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yock
force-pushed
the
refactor--artifacts-under-builds
branch
2 times, most recently
from
84aa2ae
to
12a628d
Compare
yock
force-pushed
the
refactor--artifacts-under-builds
branch
from
12a628d
to
2f4cbb0
Compare
This update does a few things * Upgrades to CircleCI API version 1.1 * Uses uses their endpoint for latest build artifacts * Flattens the call stack for retrieving artifacts * Provides a general purpose CircleCI API client for future use * Creates a seam for supporting other artifact sources Even though this is a significat refactoring, since no end-user changes are required this receives a minor version bump to 1.3.
yock
force-pushed
the
refactor--artifacts-under-builds
branch
from
2f4cbb0
to
fc71f78
Compare
This was referenced Oct 12, 2016
Merged
patricksimpson
suggested changes
Oct 12, 2016
There was a problem hiding this comment.
I will need to test this locally before merging. Let's setup a time for a review/test this week! Thanks @yock
| @@ -1,28 +1,18 @@ | |||
| PATH | |||
| remote: . | |||
| specs: | |||
| mina-circle (1.2.1) | |||
| mina-circle (1.3) | |||
There was a problem hiding this comment.
should we be using 1.3.0?
There was a problem hiding this comment.
Yeah, I realized that when I bumped the version on #35. I'll fix it tonight-ish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.