fixed input coverage

sparkdesignsystem · Dec 5, 2018 · 303b48f · 303b48f
1 parent 0d93f1c
commit 303b48f
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 9 deletions.
diff --git a/packages/spark-core/tests/requiredTick.tests.js b/packages/spark-core/tests/requiredTick.tests.js
@@ -112,6 +112,12 @@ describe('requiredTextInput UI Events tests', () => {
     expect(errorContainer.textContent).eql('This field is required.');
   });
 
+  it('should run validation on focusout', () => {
+    event = new window.Event('focusout');
+    inputContainer.dispatchEvent(event);
+    expect(errorContainer.textContent).eql('This field is required.');
+  });
+
   it('should mark valid when input is triggered with a value', () => {
     radio1.checked = true;
     event = new window.Event('change');

diff --git a/packages/spark-core/tests/setInvalidSelect.tests.js b/packages/spark-core/tests/setInvalidSelect.tests.js
@@ -1,4 +1,4 @@
-/* global document describe before it */
+/* global document describe beforeEach it */
 import { expect } from 'chai';
 import setInvalidSelect from '../utilities/validation/setInvalidSelect';
 
@@ -9,7 +9,7 @@ describe('setInvalidSelect tests', () => {
   let option2;
   let errorContainer;
 
-  before(() => {
+  beforeEach(() => {
     inputContainer = document.createElement('div');
     inputContainer.setAttribute('data-sprk-required', 'select');
     errorContainer = document.createElement('span');
@@ -25,15 +25,22 @@ describe('setInvalidSelect tests', () => {
     select.appendChild(option2);
 
     inputContainer.appendChild(select);
-    inputContainer.appendChild(errorContainer);
   });
 
   it('should set the errorContainer text', () => {
+    inputContainer.appendChild(errorContainer);
     const error = 'This is an error message';
     setInvalidSelect(inputContainer, error);
     expect(errorContainer.textContent).eql(error);
   });
+
+  it('should not error if there is no errorContainer', () => {
+    setInvalidSelect(inputContainer, 'oops.');
+    expect(select.getAttribute('aria-invalid')).eql('true');
+  });
+
   it('should support overriding the error message', () => {
+    inputContainer.appendChild(errorContainer);
     const defaultError = 'This is an error message';
     const newError = 'This is my custom error.';
     inputContainer.setAttribute('data-sprk-input-invalid-content', newError);

diff --git a/packages/spark-core/tests/setValidSelect.tests.js b/packages/spark-core/tests/setValidSelect.tests.js
@@ -1,4 +1,4 @@
-/* global document describe before it */
+/* global document describe beforeEach it */
 import { expect } from 'chai';
 import setValidSelect from '../utilities/validation/setValidSelect';
 
@@ -9,7 +9,7 @@ describe('setValidSelect tests', () => {
   let option2;
   let errorContainer;
 
-  before(() => {
+  beforeEach(() => {
     inputContainer = document.createElement('div');
     inputContainer.setAttribute('data-sprk-required', 'select');
     errorContainer = document.createElement('span');
@@ -26,11 +26,16 @@ describe('setValidSelect tests', () => {
     select.appendChild(option2);
 
     inputContainer.appendChild(select);
-    inputContainer.appendChild(errorContainer);
   });
 
   it('should empty the error container', () => {
+    inputContainer.appendChild(errorContainer);
     setValidSelect(inputContainer);
     expect(errorContainer.textContent).eql('');
   });
+
+  it('should not error if there is no error container', () => {
+    setValidSelect(inputContainer);
+    expect(select.getAttribute('aria-invalid')).eql('false');
+  });
 });
diff --git a/packages/spark-core/tests/setValidTick.tests.js b/packages/spark-core/tests/setValidTick.tests.js
@@ -1,4 +1,4 @@
-/* global document describe before it */
+/* global document describe beforeEach it */
 import { expect } from 'chai';
 import setValidTick from '../utilities/validation/setValidTick';
 
@@ -10,7 +10,7 @@ describe('setValidTick tests', () => {
   let radio2;
   let errorContainer;
 
-  before(() => {
+  beforeEach(() => {
     inputContainer = document.createElement('div');
     inputContainer.setAttribute('data-sprk-required', 'tick');
     errorContainer = document.createElement('span');
@@ -34,11 +34,16 @@ describe('setValidTick tests', () => {
 
     inputContainer.appendChild(selectionContainer1);
     inputContainer.appendChild(selectionContainer2);
-    inputContainer.appendChild(errorContainer);
   });
 
   it('should empty the error container', () => {
+    inputContainer.appendChild(errorContainer);
     setValidTick(inputContainer);
     expect(errorContainer.textContent).eql('');
   });
+
+  it('should not error if there is no error container', () => {
+    setValidTick(inputContainer);
+    expect(inputContainer.querySelector('.sprk-b-ErrorContainer')).eql(null);
+  });
 });