Update designer/developer navigation & pages #1028
Conversation
guern1kn
added
status: DO NOT MERGE
guern1kn
requested review from
afebbraro,
RCopeland and
yodasw16
as code owners
yodasw16
removed
scope: sprk site
guern1kn
removed
the
status: DO NOT MERGE
src/pages/gettingstarted/angular.hbs
Outdated
| </p> | ||
| </li> | ||
| <li class="sprk-u-mvm"> | ||
| <p>Spark does not provide icons directly. What you see below are proprietary icons in use by Quicken Loans. To supply |
There was a problem hiding this comment.
can you change it from see below to like 'see on our icons page'?
src/pages/gettingstarted/vanilla.hbs
Outdated
| @@ -0,0 +1,313 @@ | |||
| --- | |||
| title: Vanilla | |||
There was a problem hiding this comment.
maybe we should change Vanilla to HTML, i dont think its a great name, but it matches the code switch
There was a problem hiding this comment.
Updated to html throughout
src/pages/gettingstarted/vanilla.hbs
Outdated
| <ul class="drizzle-b-List drizzle-b-List--spacing-m drizzle-b-List--nested"> | ||
| <li> | ||
| <p>There are a few Spark Extras patterns available for install.</p> | ||
| <div class="drizzle-c-Command"> |
There was a problem hiding this comment.
can you put these in a list?
src/pages/gettingstarted/angular.hbs
Outdated
| </li> | ||
| <li class="sprk-u-mvm"> | ||
| <p> | ||
| Install additional peer dependencies: |
There was a problem hiding this comment.
these are listed as dev deps in the spark-core-angular project, so they shouldnt have to manually install them
There was a problem hiding this comment.
Removed reference to additional dependencies
src/pages/gettingstarted/angular.hbs
Outdated
| </div> | ||
|
|
||
| <div class="drizzle-o-ContentGrouping"> | ||
| <h3 class="drizzle-b-h3">Code Style Standards</h3> |
There was a problem hiding this comment.
i think we should move the code style stuff to the contributions page
There was a problem hiding this comment.
Removed from html and angular doc pages, moved to contributions.
name: Pull Request
about: Create a pull request to make changes to Spark.
What does this PR do?
Removes the outdated Getting Started - Designers section and breaks the Developer section into two separate Vanilla and Angular pages.
Please check off completed items as you work.
If a checklist item or section does not apply to your PR
then please remove it.
Documentation
Code
Accessibility
Browser Testing (current version and 1 prior)
Design Review
Screenshots
Add screenshots to help explain your PR if you'd like. However, this is not
expected.