This repository has been archived by the owner on Jul 26, 2018. It is now read-only.
Updates for quality #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an unused variable that served no purpose. Changed a variable type from char to int that was being used only as an array index as my compiler doesn't like chars used as indices.
|
Hi Neil, thanks for looking at this code and your debugging. Re. char to int, I hate to waste a byte of SRAM if I don't have to; how about changing it to a uint8_t? (The whole library could frankly use that for better portability). |
|
Also out of curiosity, what compiler / destination processor are you using? |
|
I'm compiling using xtensa-esp32-elf-gcc which reports as 4.8.5. The target is for the ESP32. |
|
Changed to uint8_t |
|
Thanks VERY much Neil, if you ever see anything else that can be improved, please let us know! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an unused variable that served no purpose.
Changed a variable type from char to int that was being used only as an array index
as my compiler doesn't like chars used as indices.