Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Swift Argument parser for Swift tools #1913

Merged
merged 8 commits into from
Aug 1, 2021
Merged

Adopt Swift Argument parser for Swift tools #1913

merged 8 commits into from
Aug 1, 2021

Conversation

zorgiepoo
Copy link
Member

Adopt Swift Argument parser for Swift tools: generate_keys, sign_update, generate_appcast
Before investigation of adding new options to generate_appcast, we should improve its argument parsing.

I referenced some bits of #1608

Fixes #1583

cc @Wevah

Checklist:

  • My change is being tested and reviewed against the Sparkle 2.x branch. New changes must be developed on the 2.x development branch first.
  • My change is being backported to master branch (Sparkle 1.x). Please create a separate pull request for 1.x, should it be backported. Note 1.x is feature frozen and is only taking bug fixes, localization updates, and critical OS adoption enhancements.
  • I have reviewed and commented my code, particularly in hard-to-understand areas.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • My change is or requires a documentation or localization update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

I tested command line invocations (all potential options) for sign_update, generate_keys, and generate_appcast and tested invalid combinations of options to make sure they were rejected. For simplicity, I dropped the deprecated DSA argument support for generate_appcast in favor of using the DSA argument option (-f).

macOS version tested: 11.5.1 (20G80)

@zorgiepoo zorgiepoo merged commit 4f7ed34 into 2.x Aug 1, 2021
@zorgiepoo zorgiepoo deleted the argument-parser branch August 1, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On hold: Update swift helpers to use Swift Argument Parser
2 participants