Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bundle URLs #882

Merged
merged 3 commits into from Sep 3, 2016
Merged

Use bundle URLs #882

merged 3 commits into from Sep 3, 2016

Conversation

kornelski
Copy link
Member

Use bundle URLs instead of paths to avoid creation of temp bundle objects

@kornelski
Copy link
Member Author

I hope this change doesn't touch Swift tests, because they need syntax changes in the latest xcode :)

@zorgiepoo
Copy link
Member

Good idea. SUCodeSigningVerifierTest.m has a lot of mismatched paths/url code (eg: naming a variable a URL and assigning it a NSString, or invoking URL method on a NSString). I'm guessing it's probably why the tests are failing. Other than that I think it looks good. Don't think swift is involved here.

@kornelski kornelski merged commit 077c644 into master Sep 3, 2016
@kornelski kornelski deleted the bundleurl branch September 3, 2016 16:09
@zorgiepoo
Copy link
Member

You can use -[NSURL checkResourceIsReachableAndReturnError:] instead of -[NSFileManager fileExistsAtPath:] to remove the nullability warnings in SUCodeSigningVerifier.m

@kornelski kornelski mentioned this pull request Sep 4, 2016
Merged
@kornelski
Copy link
Member Author

Thanks. I didn't know it existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kornelski @zorgiepoo