Handle breaking changes from psych gem #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe @knu could have a look at it? I'm already tired resetting psych from 4 to 3 :D |
4 tasks
Shouldn't be in conflict with older ruby versions since they don't have unsafe_load
olleolleolle
reviewed
Jun 5, 2021
Supporting older ruby versions which don't have method_defined? Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
|
Thanks. Because this gem needs to support legacy versions of ruby including 1.8 and the CI for 1.8.7/REE is broken due to the OpenSSL compatibility problem, I'll fix this myself and test it locally with 1.8.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already mentioned in ruby/psych#503 (comment) psych had some breaking changes which breaks fastlane on the other hand.