Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore fields without names in Form#build_query #542

Merged
merged 1 commit into from Feb 12, 2019

Conversation

@leejarvis
Copy link
Member

@leejarvis leejarvis commented Feb 11, 2019

We shouldn't try to submit empty strings to the server, since browsers
also simply ignore these fields

Fixes #536

@leejarvis leejarvis requested a review from knu Feb 11, 2019
@leejarvis
Copy link
Member Author

@leejarvis leejarvis commented Feb 11, 2019

Failure is being discussed in #537

@knu Please can you sense-check?

@knu
knu approved these changes Feb 12, 2019
Copy link
Member

@knu knu left a comment

LGTM!

We shouldn't try to submit empty strings to the server, since browsers
also simply ignore these fields

Fixes #536
@leejarvis leejarvis force-pushed the ignore-fields-with-no-names branch from de37499 to 361bfe6 Feb 12, 2019
@leejarvis leejarvis merged commit b4fc210 into master Feb 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants