Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with ruby 3.3, accommodate new libxml2 behavior #630

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Dec 29, 2023

Add Ruby 3.3 to the test matrix.

Also, update an encoding test to pass with the latest libxml2 (v2.12) delivered by the latest nokogiri (v1.16).

As of libxml 2.12.0, the `page.encoding` value inspected by this test
is dependent on how libiconv is built (specifically: which aliases are
supported).

- if alias "UTF8" is defined, then the page encoding will be "UTF-8"
- if alias "UTF8" is not defined, then the page encoding will be "UTF8"

The modified test started failing on Windows and MacOS (where Nokogiri
compiles libiconv and statically links it into the
native (precompiled) gem) but still passed on Linux (where libc
dynamically provides libiconv symbols).
@flavorjones flavorjones changed the title ci: update github actions to test ruby 3.3 ci: test with ruby 3.3, accommodate new libxml2 behavior Dec 29, 2023
@flavorjones flavorjones merged commit d52c39a into main Dec 29, 2023
12 checks passed
@flavorjones flavorjones deleted the flavorjones-update-ci-ruby-33 branch December 29, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant