Skip to content

Commit

Permalink
dev: rubocop rake task is no longer a prereq for test
Browse files Browse the repository at this point in the history
- instead, make `rubocop` a prereq for `default`
- also make `compile` a preqreq for `default`
- and update the CI task to explicitly run the `rubocop` task

This was driven out by introducing TruffleRuby to CI, which doesn't
yet fully support rubocop.

Part of #2089
  • Loading branch information
flavorjones committed Oct 1, 2020
1 parent 793baae commit 3aad334
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 4 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,8 @@ require_relative "tasks/docs-linkify"
require_relative "tasks/rubocop"
require_relative "tasks/set-version-to-timestamp"

# work around Hoe's inflexibility about the default tasks
Rake::Task[:default].prerequisites.unshift("compile")
Rake::Task[:default].prerequisites.unshift("rubocop")

# vim: syntax=Ruby
2 changes: 1 addition & 1 deletion concourse/tasks/rake-test/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ pushd nokogiri

code-climate-setup

bundle exec rake compile ${test_task}
bundle exec rake rubocop compile ${test_task}

code-climate-shipit

Expand Down
2 changes: 0 additions & 2 deletions tasks/rubocop.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@
task :rubocop_frozen_string_literals do
sh "rubocop lib --auto-correct-all --only Style/FrozenStringLiteralComment"
end

task :test => :rubocop

0 comments on commit 3aad334

Please sign in to comment.