Skip to content

Commit

Permalink
Changing gem build process to use 1.8.7. Ugh.
Browse files Browse the repository at this point in the history
  • Loading branch information
@flavorjones
flavorjones committed Mar 9, 2012
1 parent 8c253d2 commit 9e4fc42
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build_all
View file
Expand Up @@ -27,7 +27,7 @@ function rvm_use {
set -o errexit

# initialize
rvm_use 1.9.3
rvm_use 1.8.7
rm -rf tmp pkg
bundle exec rake clean clobber

Expand All @@ -36,7 +36,7 @@ rm -rf gems
mkdir -p gems

# MRI
rvm_use 1.9.3
rvm_use 1.8.7
bundle exec rake gem
cp -v pkg/nokogiri*.gem gems # should only be one at this point in the script

Expand Down

3 comments on commit 9e4fc42

@wokkaflokka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but this commit fixed the incompatible gemspec issue on 1.8.7 that existed between this morning and just now?

I didn't notice any oddities using Noko on 1.9.3, but all of my automated builds died horribly today until approximately 15 minutes ago.

@flavorjones
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. See issues #631 and #632 for background.

@wokkaflokka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

Please sign in to comment.