Merge pull request #858 from ykzts/feature/not-only-child

Add feature that the ':only-child' pseudo class should work even though it's in ':not' pseudo class.
sparklemotion · Jun 14, 2013 · d1b0afd · d1b0afd
2 parents d24eb85 + 4383dc6
commit d1b0afd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/nokogiri/css/xpath_visitor.rb b/lib/nokogiri/css/xpath_visitor.rb
@@ -109,6 +109,7 @@ def visit_pseudo_class node
           when "last", "last-child" then "position() = last()"
           when "first-of-type" then "position() = 1"
           when "last-of-type" then "position() = last()"
+          when "only-child" then "last() = 1"
           when "only-of-type" then "last() = 1"
           when "empty" then "not(node())"
           when "parent" then "node()"

diff --git a/test/css/test_xpath_visitor.rb b/test/css/test_xpath_visitor.rb
@@ -17,6 +17,11 @@ def test_not_last_child
           @parser.parse('ol > *:not(:last-child)'))
       end
 
+      def test_not_only_child
+        assert_xpath('//ol/*[not(last() = 1)]',
+          @parser.parse('ol > *:not(:only-child)'))
+      end
+
       def test_function_calls_allow_at_params
         assert_xpath("//a[foo(., @href)]", @parser.parse('a:foo(@href)'))
         assert_xpath("//a[foo(., @a, b)]", @parser.parse('a:foo(@a, b)'))