ci: test installed gem on java 8

sparklemotion · May 23, 2023 · ff2c996 · ff2c996
1 parent 25b2166
commit ff2c996
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -699,7 +699,6 @@ jobs:
 
   jruby-package:
     needs: ["rcd_image_version"]
-    name: "jruby-package"
     runs-on: ubuntu-latest
     container:
       image: "ghcr.io/rake-compiler/rake-compiler-dock-image:${{needs.rcd_image_version.outputs.rcd_image_version}}-jruby"
@@ -719,17 +718,19 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["jruby-9.4"]
+        jruby: ["9.4"]
+        jre: ["8", "11"]
+    name: "jruby-${{matrix.jruby}}-jre${{matrix.jre}}-install"
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
         with:
           submodules: true
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: "${{matrix.ruby}}"
       - uses: actions/download-artifact@v3
         with:
           name: jruby-gem
           path: gems
-      - run: ./scripts/test-gem-install gems
+      - run: |
+          docker run --rm -v "$(pwd):/nokogiri" -w /nokogiri \
+            jruby:${{matrix.jruby}}-jre${{matrix.jre}} \
+            ./scripts/test-gem-install gems
diff --git a/rakelib/extensions.rake b/rakelib/extensions.rake
@@ -362,6 +362,12 @@ namespace "gem" do
 end
 
 if java?
+  # append to the existing "java" task defined by rake-compiler
+  task "java" do # rubocop:disable Rake/Desc
+    # if we're building the java gem, don't build the vanilla gem (see rakelib/package.rake)
+    Rake::Task["pkg/#{NOKOGIRI_SPEC.full_name}.gem"].clear
+  end
+
   require "rake/javaextensiontask"
   Rake::JavaExtensionTask.new("nokogiri", NOKOGIRI_SPEC.dup) do |ext|
     # Keep the extension C files because they have docstrings (and Java files don't)