Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove EncodingHandler from the JRuby implementation #2446

Closed
flavorjones opened this issue Feb 8, 2022 · 0 comments · Fixed by #2643
Closed

cleanup: Remove EncodingHandler from the JRuby implementation #2446

flavorjones opened this issue Feb 8, 2022 · 0 comments · Fixed by #2643
Labels
platform/jruby topic/encoding
Milestone
v1.14.0

Comments

@flavorjones
Copy link
Member

flavorjones commented Feb 8, 2022 •
edited

This class exists only to manage libiconv encoding aliases, and does nothing in JRuby.

I think we should try to write more-meaningful tests, as well.
@flavorjones flavorjones added this to the v1.14.0 milestone Feb 8, 2022
flavorjones added a commit that referenced this issue Aug 30, 2022
@flavorjones
cleanup: EncodingHandler
bc7e9b7 
- remove EncodingHandler from the JRuby codebase (it's not needed)
- move initialization to Nokogiri::EncodingHandler.install_default_aliases
- deprecate Nokogiri.install_default_aliases
- install a sentinal value to indicate Nokogiri has loaded aliases
- minispec-ify the tests

Closes #2446
@flavorjones flavorjones mentioned this issue Aug 30, 2022
Merged
flavorjones added a commit that referenced this issue Aug 30, 2022
@flavorjones
cleanup: EncodingHandler
1e21d8b 
- rewrite the shim Java implementation of EncodingHandler in Ruby (because it's a big no-op)
- move initialization to Nokogiri::EncodingHandler.install_default_aliases
- deprecate Nokogiri.install_default_aliases
- install a sentinel value to indicate Nokogiri has loaded aliases
- minispec-ify the tests
- improve docs

Closes #2446
flavorjones added a commit that referenced this issue Aug 30, 2022
@flavorjones
cleanup: EncodingHandler
b2390a4 
- rewrite the shim Java implementation of EncodingHandler in Ruby (because it's a big no-op)
- move initialization to Nokogiri::EncodingHandler.install_default_aliases
- deprecate Nokogiri.install_default_aliases
- install a sentinel value to indicate Nokogiri has loaded aliases
- minispec-ify the tests
- improve docs

Closes #2446
flavorjones added a commit that referenced this issue Aug 30, 2022
@flavorjones
cleanup: EncodingHandler
11df954 
- rewrite the shim Java implementation of EncodingHandler in Ruby (because it's a big no-op)
- move initialization to Nokogiri::EncodingHandler.install_default_aliases
- deprecate Nokogiri.install_default_aliases
- install a sentinel value to indicate Nokogiri has loaded aliases
- minispec-ify the tests
- improve docs

Closes #2446
flavorjones added a commit that referenced this issue Aug 31, 2022
@flavorjones
cleanup: EncodingHandler
d568a69 
- rewrite the shim Java implementation of EncodingHandler in Ruby (because it's a big no-op)
- move initialization to Nokogiri::EncodingHandler.install_default_aliases
- deprecate Nokogiri.install_default_aliases
- install a sentinel value to indicate Nokogiri has loaded aliases
- minispec-ify the tests
- improve docs

Closes #2446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform/jruby topic/encoding
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

cleanup: EncodingHandler sparklemotion/nokogiri
1 participant
@flavorjones