support HTML5 search element
#2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use this: cd gumbo-parser touch src/*.gperf make src/*.c
flavorjones
force-pushed
the
flavorjones-fix-upstream-html5lib-202206
branch
from
c2355bb
to
1c74c8f
Compare
stevecheckoway
approved these changes
Jun 9, 2022
|
The new search element doesn't yet appear on the web page, but from reading the changes, it looks like it only impacts the parser in the ways your commits handles. |
|
Thanks for the review! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Upstream the
<search>element has been adopted (whatwg/html#7320) and the tests were added tohtml5lib-tests(html5lib/html5lib-tests#142).The upstream tests have been failing on this for a while, so I'm attempting to add support in this PR.
Notable changes:
.gperffilessearchtagsearchin the set of tags that closepand that should have implicit end tagsHave you included adequate test coverage?
I've updated the
test/html5libs-testref to the latest that is still green.Does this change affect the behavior of either the C or the Java implementations?
The HTML5 parser is only supported in the C extension.