Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gumbo: update adjusted foreign attributes #2842

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Apr 7, 2023

What problem is this PR intended to solve?

Partial fix for #2841

A test recently added upstream showed that the list of foreign attributes gumbo is adjusting needed to be updated. Specifically:

  • add xlink:arcrole
  • remove xml:base

(see https://html.spec.whatwg.org/multipage/parsing.html#adjust-foreign-attributes)

I've also pinned (for now) to my branch of html5lib-tests, and improved some of the error messages from the tree construction test wrapper.

Have you included adequate test coverage?

This PR is all about the tests! 🎉

Does this change affect the behavior of either the C or the Java implementations?

The HTML5/gumbo functionality changed, but this does not exist in the Java implementation.

Copy link
Contributor

@stevecheckoway stevecheckoway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The changes to the test infrastructure are very welcome. Debugging why a particular test is failing was always a pain point.

@stevecheckoway
Copy link
Contributor

It might be worth thinking about how we can stay on top of changes to the spec other than following the whatwg/html repo.

@flavorjones
Copy link
Member Author

It might be worth thinking about how we can stay on top of changes to the spec other than following the whatwg/html repo.

Yeah, I'm currently following the repo and it's a bit noisy. My hope is that we can pull the html5lib-tests community together a bit more and collaborate there? We'll have to see.

@flavorjones flavorjones merged commit 6f0e3c4 into main Apr 10, 2023
@flavorjones flavorjones deleted the 2841-fix-html5lib-tests branch April 10, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants