Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to libxml2 2.11.0 or later #2865

Closed
9 tasks done
flavorjones opened this issue Apr 28, 2023 · 3 comments
Closed
9 tasks done

update to libxml2 2.11.0 or later #2865

flavorjones opened this issue Apr 28, 2023 · 3 comments

Comments

@flavorjones
Copy link
Member

flavorjones commented Apr 28, 2023

See https://discourse.gnome.org/t/libxml2-2-11-0-released/15123 for release notes.

It doesn't look like anything in here affects nokogiri security concerns, so I'm planning to include this in a 1.15.0 release, but not a 1.14.x patch release. Opinions welcome.

Lots of yak shaving to try to make this release work ...

Summary of blockers

Summary of nonblocking items

Details

@flavorjones
Copy link
Member Author

flavorjones commented Apr 29, 2023

ruby_memcheck is flagging two new leaks in this version of libxml2. I've tracked it down to schema validation of files.

Ruby reproduction:

#! /usr/bin/env ruby

require "bundler/inline"

gemfile do
  source "https://rubygems.org"
  gem "nokogiri", path: "."
end

ASSETS_DIR = File.expand_path(File.join(File.dirname(__FILE__), "..", "test", "files"))
PO_SCHEMA_FILE = File.join(ASSETS_DIR, "po.xsd")
PO_XML_FILE = File.join(ASSETS_DIR, "po.xml")

loop do
  xsd = Nokogiri::XML::Schema(File.read(PO_SCHEMA_FILE))

  # leaks
  xsd.validate(PO_XML_FILE)

  # does not leak
  xsd.validate(Nokogiri::XML(File.read(PO_XML_FILE)))
end

C reproduction is at https://gist.github.com/flavorjones/0902cfc1467d44417979060dd3f11971

And upstream issue was opened at memory leak from `xmlSchemaValidateStream` in v2.11.x (#530) · Issues · GNOME / libxml2 · GitLab

@flavorjones flavorjones changed the title update to libxml2 2.11.0 update to libxml2 2.11.0 or later Apr 30, 2023
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue May 10, 2023
@flavorjones
Copy link
Member Author

IT IS DONE. See #2866

@flavorjones
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant