Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI containers' valgrind is no longer running #2909

Closed
flavorjones opened this issue Jun 22, 2023 · 1 comment · Fixed by #2910
Closed

CI containers' valgrind is no longer running #2909

flavorjones opened this issue Jun 22, 2023 · 1 comment · Fixed by #2910
Labels
topic/ci

Comments

@flavorjones
Copy link
Member

This week, something changed and valgrind is failing to start up:

https://github.com/sparklemotion/nokogiri/actions/runs/5331574365

This issue is a placeholder for investigating and fixing it.
@flavorjones
Copy link
Member Author

OK, pretty sure this is because the base image (ruby:3.2) switched from bullseye to bookworm last week.

docker-library/ruby@ed1be47

See #2721 for a prior example of running into DWARF5 data that requires valgrind 3.20 or later. The ruby:3.2 bookworm image has valgrind 3.19.

flavorjones added a commit that referenced this issue Jun 22, 2023
@flavorjones
ci: build mri-3.2 image with modern valgrind
dc083e2 
otherwise we run into DWARF5 format issues.

Closes #2909
@flavorjones flavorjones mentioned this issue Jun 22, 2023
Merged
flavorjones added a commit that referenced this issue Jun 22, 2023
@flavorjones
ci: build mri-3.2 image with modern valgrind
393eb1c 
otherwise we run into DWARF5 format issues.

Closes #2909
flavorjones added a commit that referenced this issue Jun 22, 2023
@flavorjones
ci: build mri-3.2 image with modern valgrind (#2910)
a2c0073 
**What problem is this PR intended to solve?**

Build mri-3.2 image with modern valgrind from source. Otherwise we run
into DWARF5 format issues.

Closes #2909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: build mri-3.2 image with modern valgrind sparklemotion/nokogiri
1 participant
@flavorjones