Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mini_portile2 gem to 2.5.0 #2005

Merged
merged 2 commits into from
Feb 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ Either way, we'd appreciate some feedback at [#1983](https://github.com/sparklem

### Dependencies

#### Ruby

This release introduces support for:

* Ruby 2.7, including the precompiled native binary gems for Windows.
Expand All @@ -54,6 +56,11 @@ This release ends support for:
* JRuby 9.1, which is the Ruby 2.3-compatible release.


#### Gems

* [MRI] Upgrade mini_portile2 dependency from `~> 2.4.0` to `~> 2.5.0` [[#2005](https://github.com/sparklemotion/nokogiri/issues/2005)] (Thanks, [@alejandroperea](https://github.com/alejandroperea)!)


### Added

* Add Node methods for manipulating keyword attributes (like `class` and `rel`): `#kwattr_values`, `#kwattr_add`, `#kwattr_append`, and `#kwattr_remove`. [[#2000](https://github.com/sparklemotion/nokogiri/issues/2000)]
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

source "https://rubygems.org/"

gem "mini_portile2", "~>2.4.0"
gem "mini_portile2", "~>2.5.0"

gem "concourse", "~>0.30", :group => [:development, :test]
gem "hoe", "~>3.22", ">=3.22.1", :group => [:development, :test]
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ HOE = Hoe.spec 'nokogiri' do

unless java?
self.extra_deps += [
["mini_portile2", "~> 2.4.0"], # keep version in sync with extconf.rb
["mini_portile2", "~> 2.5.0"], # keep version in sync with extconf.rb
]
end

Expand Down
2 changes: 1 addition & 1 deletion ext/nokogiri/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ def using_system_libraries?
# The gem version constraint in the Rakefile is not respected at install time.
# Keep this version in sync with the one in the Rakefile !
require 'rubygems'
gem 'mini_portile2', '~> 2.4.0'
gem 'mini_portile2', '~> 2.5.0'
require 'mini_portile2'
message "Using mini_portile version #{MiniPortile::VERSION}\n"

Expand Down