Fix the tests in #2080 #2083
Fix the tests in #2080 #2083
Conversation
|
Code Climate has analyzed commit 9cf1b35 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.3%. View more on Code Climate. |
|
The fix looks correct based on my client test suite. Nice work! Linking to #2080 (comment) for the record. |
|
❌ Build nokogiri 1.0.676 failed (commit 20d1781d58 by @jvshahid) |
|
@flavorjones Do the above appveyor failures have anything to do with my changes? I don't think they are, but |
|
@flavorjones is there any chance we could re-trigger the appveyor build once, to see if this is a transient error? I've looked at the build log, these looks like actual errors, but I'm not 100% sure either. |
|
✅ Build nokogiri 1.0.676 completed (commit 2f71d87920 by @jvshahid) |
|
Looks good now! |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
flavorjones
force-pushed
the
repro-iso-jruby
branch
from
08a9941
to
97689e9
Compare
|
Rebased and added CHANGELOG entry |
flavorjones
force-pushed
the
repro-iso-jruby
branch
from
97689e9
to
8af3640
Compare
flavorjones
force-pushed
the
repro-iso-jruby
branch
from
8af3640
to
9cf1b35
Compare
|
✅ Build nokogiri 1.0.700 completed (commit abc79770ba by @flavorjones) |
This PR introduces three new commits on top of #2080/386ebcb5 in which @thbar adds tests showing a JRuby regression when parsing ISO-8859-1 content.