Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fine tune packaging #2143

Merged
merged 7 commits into from Dec 23, 2020
Merged

fine tune packaging #2143

merged 7 commits into from Dec 23, 2020

Commits on Dec 23, 2020

  1. style: improve readability of packaging ports and patches

    @flavorjones
    flavorjones committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    1c94afa View commit details
    Browse the repository at this point in the history

  2. dev: rename build-against-libxml2-source 

    to the more precise compile-against-libxml2-source
    @flavorjones
    flavorjones committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    ea9b2b3 View commit details
    Browse the repository at this point in the history

  3. test: ensure better isolation in the subprocess of test_version.rb

    @flavorjones
    flavorjones committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    4effe03 View commit details
    Browse the repository at this point in the history

  4. dev: cross-compile jruby gem only once 

    avoiding the (buggy) default behavior of rake-compiler-dock when no
platform is set for jruby.
    @flavorjones
    flavorjones committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    99a8f35 View commit details
    Browse the repository at this point in the history

  5. feat: provide packaged libraries' headers in ext/nokogiri/include 

    This commit introduces complete test coverage for:

- the contents of every flavor of gem file
- the filesystem after every flavor of gem installation

The key outcome of this change is to allow nokogumbo to compile
against the same headers used by Nokogiri, #1788

A secondary outcome is much improved confidence and understanding of
how we're packaging the gems and what we're putting on disk during
installation.

Closes #1788
Closes #2076
Closes #2078
    @flavorjones
    flavorjones committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    f4519f5 View commit details
    Browse the repository at this point in the history

  6. dev: build-gems verifies packaging with test-gem-file-contents

    @flavorjones
    flavorjones committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    ae389fd View commit details
    Browse the repository at this point in the history

  7. ci: gem tests check generated gems and installation behavior 

    using test-gem-file-contents and test-gem-installation
    @flavorjones
    flavorjones committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    107cebc View commit details
    Browse the repository at this point in the history