feat: adds nokogiri/cppflags to VERSION_INFO
#2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ba04a58 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 72.7% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.1% (-0.1% change). View more on Code Climate. |
the presence of CPPFLAGS suitable for compilation against nokogiri and the packaged libraries will allow us to deprecate `libxml/libxml2_path` in v1.12.x also: - change VERSION_INFO["nokogiri"] from a string to a hash - add VERSION_INFO["nokogiri"]["version"] to store the version string
flavorjones
force-pushed
the
flavorjones-version-info-cppflags
branch
from
cf92267
to
ba04a58
Compare
flavorjones
added a commit
that referenced
this pull request
Apr 7, 2021
which are present starting in Nokogiri v1.11.0.rc4. See #2145 for more information. With this change, here's what compilation looks like when Nokogiri is built with libxml2: > /home/flavorjones/.rvm/rubies/ruby-2.7.2/bin/ruby -I. ../../../../ext/nokogumbo/extconf.rb > checking for whether -I/home/flavorjones/.rvm/gems/ruby-2.7.2/gems/nokogiri-1.11.0.rc3/ext/nokogiri is accepted as CFLAGS... yes > checking for whether -I/home/flavorjones/.rvm/gems/ruby-2.7.2/gems/nokogiri-1.11.0.rc3/ext/nokogiri/include is accepted as CFLAGS... yes > checking for whether -I/home/flavorjones/.rvm/gems/ruby-2.7.2/gems/nokogiri-1.11.0.rc3/ext/nokogiri/include/libxml2 is accepted as CFLAGS... yes > checking for libxml/tree.h... yes > checking for nokogiri.h... yes > creating Makefile and here's what compilation looks like when Nokogiri is _not_ built with libxml2: > checking for whether -I/home/flavorjones/.rvm/gems/ruby-2.7.2/gems/nokogiri-1.11.0.rc3/ext/nokogiri is accepted as CFLAGS... yes > checking for libxml/tree.h... no > checking for nokogiri.h... no > checking for xmlNewDoc() in -lxml2... yes > checking for nokogiri.h in /home/flavorjones/.rvm/gems/ruby-2.7.2/gems/nokogiri-1.11.0.rc3/ext/nokogiri... yes > creating Makefile In a future update, once we've pinned the Nokogiri dependency to "~> 1.11", we should be able to remove the stanza that looks at `libxml2_path`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the presence of CPPFLAGS suitable for compilation against nokogiri and
the packaged libraries will allow us to deprecate
libxml/libxml2_pathin v1.12.xalso:
What problem is this PR intended to solve?
I'd like to make sure we have a mechanism in place in v1.11.x that will replace `VERSION_INFO["libxml"]["libxml2_path"] so that we can deprecate it. With this value, another gem's extconf is as simple as:
Have you included adequate test coverage?
Yes, test coverage added to
test/test_version.rbandscripts/test-gem-installationDoes this change affect the behavior of either the C or the Java implementations?
No.